Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase YouTube TEST_TIMEOUT to 2.5s #1359

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Increase YouTube TEST_TIMEOUT to 2.5s #1359

merged 1 commit into from
Jul 14, 2023

Conversation

bryanlandia
Copy link

@bryanlandia bryanlandia commented Jul 14, 2023 •
edited
Loading

Change description

(setTimeout length testing if YT API is ready)
Another attempt to fix ENG-97

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

https://appsembler.atlassian.net/browse/ENG-97

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@bryanlandia
Increase YouTube TEST_TIMEOUT to 2.5s
65c5355 
(setTimeout length testing if YT API is ready)
Another attempt to fix ENG-97
@github-actions
Copy link

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 299
Current conflicts 299
Summary Good work! No added conflicts.
Comparing with master
Benchmark conflicts with main 315
Current conflicts 315
Summary Good work! No added conflicts.

@bryanlandia bryanlandia marked this pull request as ready for review July 14, 2023 17:56
@bryanlandia bryanlandia merged commit 386de8e into main Jul 14, 2023
@bryanlandia bryanlandia deleted the chore/ENG-97-increase-yt--api-ready-timeout branch July 14, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xscrio xscrio xscrio approved these changes

@amirtds amirtds Awaiting requested review from amirtds

Assignees

@amirtds amirtds

@xscrio xscrio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryanlandia @xscrio @amirtds